Skip to content

Commit

Permalink
update error message and update baselines (#27628)
Browse files Browse the repository at this point in the history
  • Loading branch information
ely-alamillo authored and RyanCavanaugh committed Apr 25, 2019
1 parent aafba36 commit 591b255
Show file tree
Hide file tree
Showing 10 changed files with 18 additions and 18 deletions.
2 changes: 1 addition & 1 deletion src/compiler/checker.ts
Expand Up @@ -31848,7 +31848,7 @@ namespace ts {
return false;
}

return grammarErrorOnFirstToken(node, Diagnostics.A_declare_modifier_is_required_for_a_top_level_declaration_in_a_d_ts_file);
return grammarErrorOnFirstToken(node, Diagnostics.Top_level_declarations_in_d_ts_files_must_start_with_either_a_declare_or_export_modifier);
}

function checkGrammarTopLevelElementsForRequiredDeclareModifier(file: SourceFile): boolean {
Expand Down
2 changes: 1 addition & 1 deletion src/compiler/diagnosticMessages.json
Expand Up @@ -139,7 +139,7 @@
"category": "Error",
"code": 1045
},
"A 'declare' modifier is required for a top level declaration in a .d.ts file.": {
"Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.": {
"category": "Error",
"code": 1046
},
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/missingRequiredDeclare.d.errors.txt
@@ -1,10 +1,10 @@
tests/cases/compiler/missingRequiredDeclare.d.ts(1,1): error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
tests/cases/compiler/missingRequiredDeclare.d.ts(1,1): error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.
tests/cases/compiler/missingRequiredDeclare.d.ts(1,9): error TS1039: Initializers are not allowed in ambient contexts.


==== tests/cases/compiler/missingRequiredDeclare.d.ts (2 errors) ====
var x = 1;
~~~
!!! error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
!!! error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.
~
!!! error TS1039: Initializers are not allowed in ambient contexts.
4 changes: 2 additions & 2 deletions tests/baselines/reference/parserEnumDeclaration3.d.errors.txt
@@ -1,9 +1,9 @@
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnumDeclaration3.d.ts(1,1): error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnumDeclaration3.d.ts(1,1): error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.


==== tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnumDeclaration3.d.ts (1 errors) ====
enum E {
~~~~
!!! error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
!!! error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.
A = 1
}
@@ -1,11 +1,11 @@
tests/cases/conformance/parser/ecmascript5/FunctionDeclarations/parserFunctionDeclaration2.d.ts(1,1): error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
tests/cases/conformance/parser/ecmascript5/FunctionDeclarations/parserFunctionDeclaration2.d.ts(1,1): error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.
tests/cases/conformance/parser/ecmascript5/FunctionDeclarations/parserFunctionDeclaration2.d.ts(1,14): error TS1183: An implementation cannot be declared in ambient contexts.


==== tests/cases/conformance/parser/ecmascript5/FunctionDeclarations/parserFunctionDeclaration2.d.ts (2 errors) ====
function F() {
~~~~~~~~
!!! error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
!!! error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.
~
!!! error TS1183: An implementation cannot be declared in ambient contexts.
}
@@ -1,8 +1,8 @@
tests/cases/conformance/parser/ecmascript5/ModuleDeclarations/parserModuleDeclaration1.d.ts(1,1): error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
tests/cases/conformance/parser/ecmascript5/ModuleDeclarations/parserModuleDeclaration1.d.ts(1,1): error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.


==== tests/cases/conformance/parser/ecmascript5/ModuleDeclarations/parserModuleDeclaration1.d.ts (1 errors) ====
module "Foo" {
~~~~~~
!!! error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
!!! error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.
}
@@ -1,8 +1,8 @@
tests/cases/conformance/parser/ecmascript5/ModuleDeclarations/parserModuleDeclaration2.d.ts(1,1): error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
tests/cases/conformance/parser/ecmascript5/ModuleDeclarations/parserModuleDeclaration2.d.ts(1,1): error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.


==== tests/cases/conformance/parser/ecmascript5/ModuleDeclarations/parserModuleDeclaration2.d.ts (1 errors) ====
module M {
~~~~~~
!!! error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
!!! error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.
}
@@ -1,11 +1,11 @@
tests/cases/conformance/parser/ecmascript5/ModuleDeclarations/parserModuleDeclaration4.d.ts(1,1): error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
tests/cases/conformance/parser/ecmascript5/ModuleDeclarations/parserModuleDeclaration4.d.ts(1,1): error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.
tests/cases/conformance/parser/ecmascript5/ModuleDeclarations/parserModuleDeclaration4.d.ts(2,3): error TS1038: A 'declare' modifier cannot be used in an already ambient context.


==== tests/cases/conformance/parser/ecmascript5/ModuleDeclarations/parserModuleDeclaration4.d.ts (2 errors) ====
module M {
~~~~~~
!!! error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
!!! error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.
declare module M1 {
~~~~~~~
!!! error TS1038: A 'declare' modifier cannot be used in an already ambient context.
Expand Down
@@ -1,10 +1,10 @@
tests/cases/conformance/parser/ecmascript5/Statements/parserVariableStatement1.d.ts(1,1): error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
tests/cases/conformance/parser/ecmascript5/Statements/parserVariableStatement1.d.ts(1,1): error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.
tests/cases/conformance/parser/ecmascript5/Statements/parserVariableStatement1.d.ts(1,9): error TS1039: Initializers are not allowed in ambient contexts.


==== tests/cases/conformance/parser/ecmascript5/Statements/parserVariableStatement1.d.ts (2 errors) ====
var v = 1;
~~~
!!! error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
!!! error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.
~
!!! error TS1039: Initializers are not allowed in ambient contexts.
@@ -1,7 +1,7 @@
tests/cases/conformance/parser/ecmascript5/Statements/parserVariableStatement2.d.ts(1,1): error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
tests/cases/conformance/parser/ecmascript5/Statements/parserVariableStatement2.d.ts(1,1): error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.


==== tests/cases/conformance/parser/ecmascript5/Statements/parserVariableStatement2.d.ts (1 errors) ====
var v;
~~~
!!! error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.
!!! error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.

0 comments on commit 591b255

Please sign in to comment.