Plugin probe location is higher priority than peer node_modules (#51079)

Fixes #34616
microsoft · Oct 6, 2022 · 5f3e6cc · 5f3e6cc
1 parent 2648f6a
commit 5f3e6cc
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/src/server/project.ts b/src/server/project.ts
@@ -1606,6 +1606,16 @@ namespace ts.server {
             return !!this.program && this.program.isSourceOfProjectReferenceRedirect(fileName);
         }
 
+        /*@internal*/
+        protected getGlobalPluginSearchPaths() {
+            // Search any globally-specified probe paths, then our peer node_modules
+            return [
+                ...this.projectService.pluginProbeLocations,
+                // ../../.. to walk from X/node_modules/typescript/lib/tsserver.js to X/node_modules/
+                combinePaths(this.projectService.getExecutingFilePath(), "../../.."),
+            ];
+        }
+
         protected enableGlobalPlugins(options: CompilerOptions, pluginConfigOverrides: Map<any> | undefined): void {
             if (!this.projectService.globalPlugins.length) return;
             const host = this.projectService.host;
@@ -1615,14 +1625,8 @@ namespace ts.server {
                 return;
             }
 
-            // Search any globally-specified probe paths, then our peer node_modules
-            const searchPaths = [
-                ...this.projectService.pluginProbeLocations,
-                // ../../.. to walk from X/node_modules/typescript/lib/tsserver.js to X/node_modules/
-                combinePaths(this.projectService.getExecutingFilePath(), "../../.."),
-            ];
-
             // Enable global plugins with synthetic configuration entries
+            const searchPaths = this.getGlobalPluginSearchPaths();
             for (const globalPluginName of this.projectService.globalPlugins) {
                 // Skip empty names from odd commandline parses
                 if (!globalPluginName) continue;
@@ -2530,10 +2534,7 @@ namespace ts.server {
                 return;
             }
 
-            // Search our peer node_modules, then any globally-specified probe paths
-            // ../../.. to walk from X/node_modules/typescript/lib/tsserver.js to X/node_modules/
-            const searchPaths = [combinePaths(this.projectService.getExecutingFilePath(), "../../.."), ...this.projectService.pluginProbeLocations];
-
+            const searchPaths = this.getGlobalPluginSearchPaths();
             if (this.projectService.allowLocalPluginLoads) {
                 const local = getDirectoryPath(this.canonicalConfigFilePath);
                 this.projectService.logger.info(`Local plugin loading enabled; adding ${local} to search paths`);