fix(51170): Completing an unimplemented property overwrites rest of l…

…ine (#51175) * fix(51170): skip insertText for class members with existing initializer * skip insertText for class members with existing tokens
microsoft · Oct 17, 2022 · 7406ee9 · 7406ee9
1 parent a1d82fc
commit 7406ee9
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 2 deletions.
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -764,7 +764,7 @@ namespace ts.Completions {
         if (preferences.includeCompletionsWithClassMemberSnippets &&
             preferences.includeCompletionsWithInsertText &&
             completionKind === CompletionKind.MemberLike &&
-            isClassLikeMemberCompletion(symbol, location)) {
+            isClassLikeMemberCompletion(symbol, location, sourceFile)) {
             let importAdder;
             ({ insertText, isSnippet, importAdder, replacementSpan } = getEntryForMemberCompletion(host, program, options, preferences, name, symbol, location, contextToken, formatContext));
             sortText = SortText.ClassMemberSnippets; // sortText has to be lower priority than the sortText for keywords. See #47852.
@@ -846,7 +846,7 @@ namespace ts.Completions {
         };
     }
 
-    function isClassLikeMemberCompletion(symbol: Symbol, location: Node): boolean {
+    function isClassLikeMemberCompletion(symbol: Symbol, location: Node, sourceFile: SourceFile): boolean {
         // TODO: support JS files.
         if (isInJSFile(location)) {
             return false;
@@ -884,6 +884,7 @@ namespace ts.Completions {
                     location.parent.parent &&
                     isClassElement(location.parent) &&
                     location === location.parent.name &&
+                    location.parent.getLastToken(sourceFile) === location.parent.name &&
                     isClassLike(location.parent.parent)
                 ) ||
                 (

diff --git a/...rslash/completionsOverridingProperties.ts → ...slash/completionsOverridingProperties1.ts b/...rslash/completionsOverridingProperties.ts → ...slash/completionsOverridingProperties1.ts
diff --git a/tests/cases/fourslash/completionsOverridingProperties2.ts b/tests/cases/fourslash/completionsOverridingProperties2.ts
@@ -0,0 +1,21 @@
+/// <reference path="fourslash.ts" />
+
+////interface I {
+////    prop: string;
+////}
+////class C implements I {
+////    public pr/**/: string = 'foo';
+////}
+
+verify.completions({
+    marker: "",
+    includes: [
+        { name: "prop", isSnippet: undefined, insertText: undefined }
+    ],
+    isNewIdentifierLocation: true,
+    preferences: {
+        includeCompletionsWithInsertText: true,
+        includeCompletionsWithSnippetText: true,
+        includeCompletionsWithClassMemberSnippets: true,
+    }
+});
diff --git a/tests/cases/fourslash/completionsOverridingProperties3.ts b/tests/cases/fourslash/completionsOverridingProperties3.ts
@@ -0,0 +1,21 @@
+/// <reference path="fourslash.ts" />
+
+////interface I {
+////    prop: string;
+////}
+////class C implements I {
+////    public pr/**/: string | number;
+////}
+
+verify.completions({
+    marker: "",
+    includes: [
+        { name: "prop", isSnippet: undefined, insertText: undefined }
+    ],
+    isNewIdentifierLocation: true,
+    preferences: {
+        includeCompletionsWithInsertText: true,
+        includeCompletionsWithSnippetText: true,
+        includeCompletionsWithClassMemberSnippets: true,
+    }
+});