fix(50079): show deprecated on JSX attributes (#50084)

microsoft · Sep 1, 2022 · bcf9949 · bcf9949
1 parent 5df09a5
commit bcf9949
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -28375,6 +28375,7 @@ namespace ts {
          */
         function createJsxAttributesTypeFromAttributesProperty(openingLikeElement: JsxOpeningLikeElement, checkMode: CheckMode | undefined) {
             const attributes = openingLikeElement.attributes;
+            const attributesType = getContextualType(attributes, ContextFlags.None);
             const allAttributesTable = strictNullChecks ? createSymbolTable() : undefined;
             let attributesTable = createSymbolTable();
             let spread: Type = emptyJsxObjectType;
@@ -28403,6 +28404,12 @@ namespace ts {
                     if (attributeDecl.name.escapedText === jsxChildrenPropertyName) {
                         explicitlySpecifyChildrenAttribute = true;
                     }
+                    if (attributesType) {
+                        const prop = getPropertyOfType(attributesType, member.escapedName);
+                        if (prop && prop.declarations && isDeprecatedSymbol(prop)) {
+                            addDeprecatedSuggestion(attributeDecl.name, prop.declarations, attributeDecl.name.escapedText as string);
+                        }
+                    }
                 }
                 else {
                     Debug.assert(attributeDecl.kind === SyntaxKind.JsxSpreadAttribute);

diff --git a/tests/cases/fourslash/jsdocDeprecated_suggestion18.ts b/tests/cases/fourslash/jsdocDeprecated_suggestion18.ts
@@ -0,0 +1,25 @@
+///<reference path="fourslash.ts" />
+
+// @jsx: preserve
+// @filename: foo.tsx
+////interface Props {
+////    /** @deprecated  */
+////    x: number;
+////    y: number;
+////}
+////function A(props: Props) {
+////    return <div>{props.y}</div>
+////}
+////function B() {
+////    return <A [|x|]={1} [|y|]={1} />
+////}
+
+const [range] = test.ranges();
+verify.getSuggestionDiagnostics([
+    {
+        "code": 6385,
+        "message": "'x' is deprecated.",
+        "reportsDeprecated": true,
+        "range": range
+    },
+]);