Skip to content

Commit

Permalink
Add comment providing context on the change
Browse files Browse the repository at this point in the history
  • Loading branch information
ahejlsberg committed May 13, 2019
1 parent a65f35b commit d292346
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/compiler/checker.ts
Expand Up @@ -20387,6 +20387,7 @@ namespace ts {

function isValidPropertyAccessForCompletions(node: PropertyAccessExpression | ImportTypeNode | QualifiedName, type: Type, property: Symbol): boolean {
return isValidPropertyAccessWithType(node, node.kind === SyntaxKind.PropertyAccessExpression && node.expression.kind === SyntaxKind.SuperKeyword, property.escapedName, type);
// Previously we validated the 'this' type of methods but this adversely affected performance. See #31377 for more context.
}

function isValidPropertyAccessWithType(
Expand Down

0 comments on commit d292346

Please sign in to comment.