Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/TypeScript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.9.7
Choose a base ref
...
head repository: microsoft/TypeScript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.0.2
Choose a head ref

Commits on Oct 31, 2018

  1. add skeleton

    bigaru committed Oct 31, 2018
    Copy the full SHA
    8cb019d View commit details
  2. add getAvailableActions

    bigaru committed Oct 31, 2018
    Copy the full SHA
    6cfbee7 View commit details
  3. add working getEditsForAction

    bigaru committed Oct 31, 2018
    Copy the full SHA
    f558f2f View commit details
  4. add multi vardecl

    bigaru committed Oct 31, 2018
    Copy the full SHA
    4c80de9 View commit details
  5. fix multi decl bug

    bigaru committed Oct 31, 2018
    Copy the full SHA
    367f47e View commit details
  6. change refactor name

    bigaru committed Oct 31, 2018
    Copy the full SHA
    e697856 View commit details
  7. Copy the full SHA
    cc07d68 View commit details
  8. Copy the full SHA
    05c44f1 View commit details
  9. Copy the full SHA
    d771865 View commit details
  10. fix bug modifiers by toNamed

    bigaru committed Oct 31, 2018
    Copy the full SHA
    62b9fcc View commit details
  11. add tests for modifiers

    bigaru committed Oct 31, 2018
    Copy the full SHA
    c25726e View commit details
  12. fix for tslint error

    bigaru committed Oct 31, 2018
    Copy the full SHA
    7c78cd5 View commit details
  13. adapt one test case

    bigaru committed Oct 31, 2018
    Copy the full SHA
    152e362 View commit details
  14. Copy the full SHA
    6922f6c View commit details
  15. refactor small progress

    bigaru committed Oct 31, 2018
    Copy the full SHA
    39c3928 View commit details
  16. extract creation of block

    bigaru committed Oct 31, 2018
    Copy the full SHA
    a9cb623 View commit details
  17. Copy the full SHA
    6bd26cd View commit details
  18. make guideline compliant

    bigaru committed Oct 31, 2018
    Copy the full SHA
    3e7dcad View commit details
  19. apply feedback from pr

    bigaru committed Oct 31, 2018
    Copy the full SHA
    649b53c View commit details
  20. Copy the full SHA
    5951318 View commit details
  21. apply feedback from pr

    bigaru committed Oct 31, 2018
    Copy the full SHA
    d97e073 View commit details
  22. add newline

    bigaru committed Oct 31, 2018
    Copy the full SHA
    0fa2fad View commit details
  23. rename testcases

    bigaru committed Oct 31, 2018
    Copy the full SHA
    1c74d0e View commit details
  24. Make conditions more expressive

    D0nGiovanni authored and bigaru committed Oct 31, 2018
    Copy the full SHA
    8bc7f43 View commit details
  25. Merge pull request #19 from D0nGiovanni/d-lambda-to-fn

    lambda to fn
    bigaru authored Oct 31, 2018
    Copy the full SHA
    6b80047 View commit details

Commits on Nov 7, 2018

  1. Copy the full SHA
    739e1e9 View commit details
  2. apply feedback from pr

    bigaru committed Nov 7, 2018
    Copy the full SHA
    dc81a7f View commit details
  3. Copy the full SHA
    5dfc71c View commit details
  4. update getAvailableActions

    bigaru committed Nov 7, 2018
    Copy the full SHA
    9a466f4 View commit details

Commits on Nov 8, 2018

  1. Copy the full SHA
    dfb86ac View commit details

Commits on Nov 9, 2018

  1. add more testcases

    bigaru committed Nov 9, 2018
    Copy the full SHA
    e1dc52f View commit details

Commits on Jan 22, 2019

  1. Copy the full SHA
    52e94d2 View commit details
  2. do not provide refactoring when it contains this

    because this behaves differently in arrow than in function
    bigaru committed Jan 22, 2019
    Copy the full SHA
    dbd5859 View commit details

Commits on Jan 23, 2019

  1. Copy the full SHA
    5ec1201 View commit details

Commits on Feb 25, 2020

  1. Copy the full SHA
    5e40f32 View commit details
  2. Copy the full SHA
    e2ece04 View commit details

Commits on Mar 31, 2020

  1. Copy the full SHA
    b9aee84 View commit details

Commits on Apr 9, 2020

  1. Always error when property overrides accessor or vice versa

    Previously this was only an error when useDefineForClassFields: true,
    but now it's an error for all code. This is a rare mistake to make, and
    usually only occurs in code written before `readonly` was available.
    
    Codefix to come in subsequent commits.
    sandersn committed Apr 9, 2020
    Copy the full SHA
    3ffe253 View commit details
  2. Copy the full SHA
    71b7695 View commit details
  3. Codefix invokes generate get-set accessor refactor

    1. Add add-all test
    2. Add codefix that delegates to get-set accessor refactor.
    
    Needs massive amounts of cleanup and deduplication.
    sandersn committed Apr 9, 2020
    Copy the full SHA
    e287c83 View commit details
  4. Copy the full SHA
    3030cd8 View commit details

Commits on Apr 10, 2020

  1. Copy the full SHA
    6eacc9c View commit details
  2. Copy the full SHA
    3428e27 View commit details
  3. Minor cleanup

    1. Fix lint.
    2. Make code easier to read.
    3. Turns some asserts into bails instead.
    sandersn committed Apr 10, 2020
    Copy the full SHA
    4d541d2 View commit details

Commits on Apr 11, 2020

  1. Copy the full SHA
    61f6005 View commit details
  2. Copy the full SHA
    d00a5c9 View commit details

Commits on Apr 19, 2020

  1. Copy the full SHA
    d00f2b5 View commit details
  2. Copy the full SHA
    b14b231 View commit details
  3. Copy the full SHA
    af4ea60 View commit details

Commits on Apr 20, 2020

  1. Copy the full SHA
    769a2f2 View commit details
Showing 4,023 changed files with 543,283 additions and 401,288 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
15 changes: 12 additions & 3 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -18,11 +18,20 @@
"@typescript-eslint/array-type": "error",

"camelcase": "off",
"@typescript-eslint/camelcase": ["error", { "properties": "never", "allow": ["^[A-Za-z][a-zA-Za-z]+_[A-Za-z]+$"] }],
"@typescript-eslint/naming-convention": [
"error",
{ "selector": "typeLike", "format": ["PascalCase"], "filter": { "regex": "^(__String|[A-Za-z]+_[A-Za-z]+)$", "match": false } },
{ "selector": "interface", "format": ["PascalCase"], "custom": { "regex": "^I[A-Z]", "match": false }, "filter": { "regex": "^I(Arguments|TextWriter|O([A-Z][a-z]+[A-Za-z]*)?)$", "match": false } },
{ "selector": "variable", "format": ["camelCase", "PascalCase", "UPPER_CASE"], "leadingUnderscore": "allow", "filter": { "regex": "^(_{1,2}filename|_{1,2}dirname|_+|[A-Za-z]+_[A-Za-z]+)$", "match": false } },
{ "selector": "function", "format": ["camelCase", "PascalCase"], "leadingUnderscore": "allow", "filter": { "regex": "^[A-Za-z]+_[A-Za-z]+$", "match": false } },
{ "selector": "parameter", "format": ["camelCase"], "leadingUnderscore": "allow", "filter": { "regex": "^(_+|[A-Za-z]+_[A-Z][a-z]+)$", "match": false } },
{ "selector": "method", "format": ["camelCase", "PascalCase"], "leadingUnderscore": "allow", "filter": { "regex": "^[A-Za-z]+_[A-Za-z]+$", "match": false } },
{ "selector": "memberLike", "format": ["camelCase"], "leadingUnderscore": "allow", "filter": { "regex": "^[A-Za-z]+_[A-Za-z]+$", "match": false } },
{ "selector": "enumMember", "format": ["camelCase", "PascalCase"], "leadingUnderscore": "allow", "filter": { "regex": "^[A-Za-z]+_[A-Za-z]+$", "match": false } },
{ "selector": "property", "format": null }
],

"@typescript-eslint/class-name-casing": "error",
"@typescript-eslint/consistent-type-definitions": ["error", "interface"],
"@typescript-eslint/interface-name-prefix": "error",
"@typescript-eslint/no-inferrable-types": "error",
"@typescript-eslint/no-misused-new": "error",
"@typescript-eslint/no-this-alias": "error",
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/Bug_report.md
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ assignees: ''

---

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
<!-- 🚨 STOP 🚨 STOP 🚨 STOP 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
18 changes: 18 additions & 0 deletions .github/tsc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"problemMatcher": [
{
"owner": "tsc",
"pattern": [
{
"regexp": "^(?:\\s+\\d+\\>)?([^\\s].*)\\((\\d+),(\\d+)\\)\\s*:\\s+(error|warning|info)\\s+(\\w{1,2}\\d+)\\s*:\\s*(.*)$",
"file": 1,
"line": 2,
"column": 3,
"severity": 4,
"code": 5,
"message": 6
}
]
}
]
}
24 changes: 15 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -16,10 +16,10 @@ jobs:

strategy:
matrix:
node-version: [10.x, 12.x, 13.x]
node-version: [10.x, 12.x, 14.x]

steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v2
with:
fetch-depth: 5
- name: Use node version ${{ matrix.node-version }}
@@ -30,12 +30,18 @@ jobs:
run: |
npm uninstall typescript --no-save
npm uninstall tslint --no-save
- name: npm install and test
run: |
npm install
npm update
npm test
- run: npm ci

# Re: https://github.com/actions/setup-node/pull/125
- name: Register Problem Matcher for TSC
run: echo "##[add-matcher].github/tsc.json"

- name: Tests
run: npm test -- --no-lint

- name: Linter
run: npm run lint:ci

- name: Validate the browser can import TypeScript
run: gulp test-browser-integration

2 changes: 2 additions & 0 deletions .github/workflows/nightly.yaml
Original file line number Diff line number Diff line change
@@ -3,6 +3,8 @@ name: Publish Nightly
on:
schedule:
- cron: '0 7 * * *'
# enable users to manually trigger with workflow_dispatch
workflow_dispatch: {}
repository_dispatch:
types: publish-nightly

23 changes: 23 additions & 0 deletions .github/workflows/twoslash-repros.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Twoslash Code Sample Repros

on:
push:
branches:
- orta-twoslash-repros
schedule:
- cron: '0 8 * * *'
repository_dispatch:
types: run-twoslash-repros

jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Use node
uses: actions/setup-node@v1
- run: |
npm init -y
npm install --save typescript@next
- uses: microsoft/TypeScript-Twoslash-Repro-Action@master
with:
github-token: ${{ secrets.TS_BOT_GITHUB_TOKEN }}
28 changes: 28 additions & 0 deletions .github/workflows/update-lkg.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Update LKG

on:
workflow_dispatch: {}

jobs:
build:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- name: Use node version 12
uses: actions/setup-node@v1
with:
node-version: 12
registry-url: https://registry.npmjs.org/

- name: Configure Git and Update LKG
run: |
git config user.email "ts_bot@rcavanaugh.com"
git config user.name "TypeScript Bot"
npm install
gulp LKG
npm test
git diff
git add ./lib
git commit -m "Update LKG"
git push
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -84,7 +84,6 @@ tests/cases/user/*/**/*.d.ts
tests/baselines/reference/dt
.failed-tests
TEST-results.xml
package-lock.json
tests/cases/user/TypeScript-React-Starter/TypeScript-React-Starter
tests/cases/user/TypeScript-Node-Starter/TypeScript-Node-Starter
tests/cases/user/TypeScript-React-Native-Starter/TypeScript-React-Native-Starter
Empty file removed .gitmodules
Empty file.
1 change: 0 additions & 1 deletion .npmrc

This file was deleted.

6 changes: 3 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
language: node_js

node_js:
- 'node'
- '14'
- '12'
- '10'
- '8'

env:
- workerCount=3 timeout=600000
@@ -18,7 +18,7 @@ branches:

install:
- npm uninstall typescript --no-save
- npm install
- npm ci

cache:
directories:
2 changes: 1 addition & 1 deletion .vscode/launch.template.json
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@
},
"sourceMaps": true,
"smartStep": true,
"preLaunchTask": "tests",
"preLaunchTask": "gulp: tests",
"console": "integratedTerminal",
"outFiles": [
"${workspaceRoot}/built/local/run.js"
43 changes: 27 additions & 16 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
@@ -4,31 +4,42 @@
"version": "2.0.0",
"tasks": [
{
"type": "shell",
"identifier": "local",
"type": "gulp",
"label": "gulp: local",
"command": "gulp",
"args": ["local"],
"group": { "kind": "build", "isDefault": true },
"problemMatcher": ["$gulp-tsc"]
"task": "local",
"group": {
"kind": "build",
"isDefault": true
},
"problemMatcher": [
"$tsc"
]
},
{
"type": "shell",
"identifier": "tsc",
"type": "gulp",
"label": "gulp: tsc",
"command": "gulp",
"args": ["tsc"],
"task": "tsc",
"group": "build",
"problemMatcher": ["$gulp-tsc"]
"problemMatcher": [
"$tsc"
]
},
{
"type": "shell",
"identifier": "tests",
"type": "gulp",
"label": "gulp: tests",
"command": "gulp",
"args": ["tests"],
"task": "tests",
"group": "build",
"problemMatcher": ["$gulp-tsc"]
"problemMatcher": [
"$tsc"
]
},
{
"type": "gulp",
"task": "services",
"label": "gulp: services",
"problemMatcher": [
"$tsc"
],
}
]
}
Loading