Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid recalculating versionPaths in loadNodeModuleFromDirectory #27537

Merged
merged 3 commits into from Apr 25, 2019
Merged

Avoid recalculating versionPaths in loadNodeModuleFromDirectory #27537

merged 3 commits into from Apr 25, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 3, 2018

We already have this as a property of packageInfo.

@ghost ghost requested a review from rbuckton October 3, 2018 23:38
@rbuckton
Copy link
Member

rbuckton commented Oct 3, 2018

There are baseline changes due to this change.

@ghost ghost assigned rbuckton Nov 16, 2018
@ghost
Copy link
Author

ghost commented Nov 16, 2018

Baselines fixed.

@RyanCavanaugh RyanCavanaugh merged commit aafba36 into master Apr 25, 2019
@RyanCavanaugh RyanCavanaugh deleted the versionPaths branch April 25, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbuckton rbuckton Awaiting requested review from rbuckton

Assignees

@rbuckton rbuckton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rbuckton @RyanCavanaugh