Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolveName: remove useless case #28669

Merged
merged 2 commits into from Apr 25, 2019

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Nov 25, 2018

PropertySignature cannot occur in a class.
The condition inside the clause required the parent to be a class, so it was never true.

This removes the case clause and the part of the condition that is now useless.

PropertySignature cannot occur in a class.
The condition inside the clause required the parent to be a class, so it was never true.

This removes the case clause and the part of the condition that is now useless.
@RyanCavanaugh RyanCavanaugh self-assigned this Jan 24, 2019
@RyanCavanaugh
Copy link
Member

@typescript-bot test this because I'm paranoid

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 24, 2019

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 19a5db2. You can monitor the build here. It should now contribute to this PR's status checks.

Copy link
Member

@RyanCavanaugh RyanCavanaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RWC appears to have some incorrect regressions of the form:

    import Foo from './Foo';
    ~~~~~~~~~~~~~~~~~~~~~~~
!!! error TS6133: 'Foo' is declared but its value is never read.
    
    export default class Bar {
      static Blah: typeof Foo;
    }

@ajafff
Copy link
Contributor Author

ajafff commented Feb 2, 2019

I cannot reproduce that error locally. It's strange that this change caused new errors at all. There must be something else going wrong.
Are you sure the baselines were up-to-date before running RWC tests on this PR?
Could it help if I merge master into this PR?

Is it possible to view the code that has new errors or are these private projects?

@RyanCavanaugh
Copy link
Member

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 2, 2019

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 19a5db2. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh
Copy link
Member

We'll try again. If the error's still there I'll try to get a usable repro - the code in those suites is mostly not shareable due to not being public.

@RyanCavanaugh
Copy link
Member

@typescript-bot test this again?

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 23, 2019

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 19a5db2. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh
Copy link
Member

Pushed up a newer copy of master to your fork, which it turns out is required. Rerunning tests

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 25, 2019

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 153538f. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh RyanCavanaugh merged commit d865ea7 into microsoft:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants