Fix #24991: Weaken narrowing for == #29840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR narrowing for
==
is now weaker for numbers, booleans, and string.Previously
==
assumed that the types could not be coerced to eachother; now we no longer prune a number, string, or boolean when comparing against a number, string, or boolean.This solution is not sound: we still prune when comparing to a literal type. Examples
This choice was made to reduce potential breaking changes. I'm open to tweaking the semantics based on RWC.
Fixes #24991