Added custom error message when trying to assign constraint type to generic type parameter #30394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eneric type parameter Fixes microsoft#29049. This also adds the new message in chained error messages. `typeParameterDiamond4.errors.txt` shows it appearing twice in the "diamond" scenario. I can't tell if this severely increased amount of nested messages is good or bad...?
|
Ping @RyanCavanaugh, could this be reviewed please? I can keep merging in master once it's verified this is the right approach. |
# Conflicts: # src/compiler/diagnosticMessages.json # tests/baselines/reference/functionTypeArgumentAssignmentCompat.errors.txt # tests/baselines/reference/genericFunctionCallSignatureReturnTypeMismatch.errors.txt # tests/baselines/reference/mappedTypeRelationships.errors.txt
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29049.
This also adds the new message in chained error messages.
typeParameterDiamond4.errors.txtshows it appearing twice in the "diamond" scenario. I can't tell if this severely increased amount of nested messages is good or bad...?I also wonder if the message should have "Although " prepended to the front to make it more clear that this is a useful suggestion?