Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add action for enabling experimentalDescorators option in user config… #30484

Conversation

amaksimovich2
Copy link
Contributor

Fixes #29035
Change message for missing experimentalDecorators option in user config file. Add action for quick fix of this case.

Copy link
Member

@sheetalkamat sheetalkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good but please add test similar to tests/cases/fourslash/codefixEnableExperimentalDecorators_blankCompilerOptions.ts for jsconfig one.

@amaksimovich2
Copy link
Contributor Author

@sheetalkamat I have added tests for jsconfig file

@DanielRosenwasser
Copy link
Member

Just as a heads up, your commits don't seem to be associated with your GitHub account. While this isn't technically a problem, you might care if you want more appropriate attribution. You can either make sure your GitHub account is associated with the email address you're using for your commits, or rebase and amend your commits to fix the author name and email.

If you don't care about any of this stuff, I can always just pull in the changes.

@amaksimovich2
Copy link
Contributor Author

amaksimovich2 commented Mar 21, 2019

@DanielRosenwasser Thanks for response! Actually it's not a problem for me, but for future requests I will change my email for associating account and commits.

@RyanCavanaugh RyanCavanaugh merged commit 5b79b94 into microsoft:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick fix for 'experimentalDecorators' error
4 participants