fix(lib): Loosen Array predicate return types
#31076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot test this |
|
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 68c9099. You can monitor the build here. It should now contribute to this PR's status checks. |
|
RWC looks good, this just needs baseline updates |
|
@typescript-bot run dt |
|
Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 68c9099. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Well, I can’t reproduce the Travis failure locally and it’s related to type generation, which was just removed in #31075. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that most
ReadonlyArraypredicates are already defined to returnunknown:https://github.com/Microsoft/TypeScript/blob/6487d1ffe0d903b1e55a187ddeb973fe0d445a2f/src/lib/es5.d.ts#L1117 https://github.com/Microsoft/TypeScript/blob/6487d1ffe0d903b1e55a187ddeb973fe0d445a2f/src/lib/es5.d.ts#L1123 https://github.com/Microsoft/TypeScript/blob/6487d1ffe0d903b1e55a187ddeb973fe0d445a2f/src/lib/es5.d.ts#L1147
Fixes #27496