Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude tests/cases/* from tslint #31095

Merged
merged 2 commits into from Apr 24, 2019

Conversation

andrewbranch
Copy link
Member

Linting doesn't run against these files in any tests or CI anyway, but if you have lint status in your editor, it can be super annoying.

Before After
Screen Shot 2019-04-24 at 10 40 11 AM Screen Shot 2019-04-24 at 10 40 39 AM

馃槃

tslint.json Outdated
@@ -1,6 +1,11 @@
{
"extends": "tslint:latest",
"rulesDirectory": "built/local/tslint/rules",
"linterOptions": {
"exclude": [
"tests/cases/**/*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be it should be everything in tests folder instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Done.

@andrewbranch andrewbranch merged commit b010010 into microsoft:master Apr 24, 2019
@andrewbranch andrewbranch deleted the tslint-exclude-tests branch April 24, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants