Update lib.d.ts: Change the type of uriComponent (passed to encodeURIComponent) from string to string | number | boolean
#31103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smockle
changed the title
uriComponent (passed to encodeURIComponent) from string to anylib.d.ts: Change the type of uriComponent (passed to encodeURIComponent) from string to any
|
Why not |
|
Consulting the spec here would lead you to believe that all functions should accept Accepting |
Thanks for the guidance! I’ll update the PR. |
smockle
changed the title
lib.d.ts: Change the type of uriComponent (passed to encodeURIComponent) from string to anylib.d.ts: Change the type of uriComponent (passed to encodeURIComponent) from string to string | number | boolean
…om 'string' to 'string | number | boolean'. Fixes #18159 - According to the ECMAScript 5.1 spec (§15.1.3.4), 'encodeURIComponent' invokes the abstract operation 'ToString': https://www.ecma-international.org/ecma-262/5.1/#sec-15.1.3.4 - In the spec (§9.8), 'ToString' accepts an 'Undefined', 'Null', 'Boolean', 'Number', 'String' or 'Object' argument: https://www.ecma-international.org/ecma-262/5.1/#sec-9.8 - TypeScript’s 'StringConstructor' accepts an argument with type 'any': https://github.com/Microsoft/TypeScript/blob/b0100100a18d740ad0b7c626bc81b800b5273ece/lib/lib.es5.d.ts#L518
|
Thanks! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18159
encodeURIComponentinvokes the abstract operationToStringToStringaccepts anUndefined,Null,Boolean,Number,StringorObjectargumentStringConstructoraccepts an argument with typeany: https://github.com/Microsoft/TypeScript/blob/b0100100a18d740ad0b7c626bc81b800b5273ece/lib/lib.es5.d.ts#L517-L518NB: This declaration also appears in
lib/lib.es5.d.ts…https://github.com/Microsoft/TypeScript/blob/b0100100a18d740ad0b7c626bc81b800b5273ece/lib/lib.es5.d.ts#L83
…but I left that file alone per the instructions in “Contributing
lib.d.tsfixes”.