Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid more useless type assertions #31239

Merged
merged 1 commit into from May 3, 2019

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented May 3, 2019

Ref: #18217

This changes the public API of createPropertyAccess to no longer allow name to be undefined. Previously that was allowed but resulted in an invalid Node.

@weswigham weswigham merged commit 4ee0084 into microsoft:master May 3, 2019
@weswigham weswigham added the Breaking Change Would introduce errors in existing code label May 3, 2019
@weswigham
Copy link
Member

Technically this is a breaking API change, but I say we take it. An undefined value there was always suspect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Would introduce errors in existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants