Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick info on 'new' keyword should be the same as that of resolved expression #31262

Merged
merged 4 commits into from May 15, 2019
Merged

Quick info on 'new' keyword should be the same as that of resolved expression #31262

merged 4 commits into from May 15, 2019

Conversation

rpgeeganage
Copy link
Contributor

@rpgeeganage rpgeeganage commented May 5, 2019 •
edited by DanielRosenwasser

This PR is an attempt to solve: #31180
(Quick info on 'new' keyword should be the same as that of resolved expression)

Fixes #31180

@rpgeeganage rpgeeganage mentioned this pull request May 5, 2019
Closed
@rpgeeganage rpgeeganage changed the title New keyword consistent resolve Quick info on 'new' keyword should be the same as that of resolved expression May 5, 2019
DanielRosenwasser
DanielRosenwasser requested changes May 6, 2019
View reviewed changes
src/services/services.ts Outdated Show resolved Hide resolved
src/services/services.ts Outdated Show resolved Hide resolved
tests/baselines/reference/quickInfoDisplayPartsTypeParameterInInterface.baseline Outdated Show resolved Hide resolved
src/services/services.ts Outdated Show resolved Hide resolved
@rpgeeganage
Copy link
Contributor Author

@DanielRosenwasser ,
I fixed the changes. Yes, the baseline files were not changed.
Sorry for the wrong approach.

I have changed the test case too. I have removed the marker 3.
////n/*1*/ew C/*2*/at(/*3*/);
because it doesn't have the same quick info and documentation marker 1 and marker 2.
is it ok?

@DanielRosenwasser DanielRosenwasser merged commit d484163 into microsoft:master May 15, 2019
@DanielRosenwasser
Copy link
Member

Thanks for the PR and the patience! 🙏🏻

@rpgeeganage
Copy link
Contributor Author

I'm honored to contribute to this wonderful repo.

@rpgeeganage rpgeeganage deleted the new_keyword_consistent_resolve branch May 15, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quick info on 'new' keyword should be the same as that of resolved expression
2 participants
@rpgeeganage @DanielRosenwasser