fix parsing of leading union/intersection operator #31265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favor of #31017 |
|
Reopening as this PR actually fixes the floating token issue if there's no further operator |
|
@rbuckton I added the test case you requested in #31017 (comment): declaration emit ignores leading comments of the leading operator. |
rbuckton
approved these changes
May 8, 2019
|
Looks good, thanks! |
dhcmrlchtdj
reviewed
May 9, 2019
|
|
||
|
|
||
| //// [unionTypeWithLeadingOperator.d.ts] | ||
| export declare type D = /*leading1*/ 1 | /*leading2*/ 2; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #30995
A leading
|or&is now part of the union/intersection type's range.If there's a leading operator and only one constituent type, we still parse a union/intersection type.