Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message regressed by #30916 #31276

Merged

Conversation

weswigham
Copy link
Member

Fixes #31271

overrideNextErrorInfo is now, rather than a boolean, a union of a message chain or undefined, this way you can only actually set it when there's already a diagnostic message queue'd up, so the same small error introduced in #30916 (a previously exhaustive error-elaboration codepath became non-exhaustive) can't be reintroduced.

@DanielRosenwasser
Copy link
Member

Seems reasonable.

@weswigham
Copy link
Member Author

@ahejlsberg (since you submitted the issue) ?

@weswigham weswigham merged commit 3885e3f into microsoft:master May 14, 2019
@weswigham weswigham deleted the fix-accidentally-suppressed-error branch May 14, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malfunctioning error suppression logic
3 participants