Add opt-in behavior for custom transforms to support bundles #31301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative approach to #29871, this PR addresses a backwards-compatibility issue when we added support for transforming
Bundle
nodes. Custom transformers have the typeTransformerFactory<SourceFile>
, as they only expect to receive source files. However, we assign them to an array ofTransformerFactory<Bundle | SourceFile>[]
and may inadvertently pass aBundle
to a transformer that is not able to support it.To address this, I've added an opt-in mechanism where custom transform authors can return a
CustomTransformer
object or the existingTransformer<SourceFile>
callback. Custom transformers are then wrapped in a callback that invokes the transformation based on whether it is a function (and correctly wraps it in a call tochainBundle
), or an object (in which case the appropriatetransformSourceFile
ortransformBundle
methods are called).Fixes #28310, #24459
Replaces #29871