Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose getTypeOfArrayLiteralOrObjectLiteralDestructuringAssignment #31564

Merged
merged 1 commit into from May 24, 2019
Merged

Expose getTypeOfArrayLiteralOrObjectLiteralDestructuringAssignment #31564

merged 1 commit into from May 24, 2019

Conversation

rbuckton
Copy link
Member

This exposes getTypeOfArrayLiteralOrObjectLiteralDestructuringAssignment on TypeChecker as getTypeOfAssignmentPattern.

@RyanCavanaugh: Should I go ahead and rename the method internally as well?

Fixes #26509

weswigham
weswigham approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rename the internal name to match - I don't see why not.

@rbuckton rbuckton merged commit b460d8c into master May 24, 2019
@rbuckton rbuckton deleted the fix26509 branch May 24, 2019 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API: expose getTypeOfArrayLiteralOrObjectLiteralDestructuringAssignment
2 participants
@rbuckton @weswigham