Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not log errors when ts server plugin is not found in one folder but is eventually resolved. #31588

Merged
merged 1 commit into from May 24, 2019
Merged

Do not log errors when ts server plugin is not found in one folder but is eventually resolved. #31588

merged 1 commit into from May 24, 2019

Conversation

sheetalkamat
Copy link
Member

Fixes #30106

sandersn
sandersn approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but I'm not sure it's possible to change the API.

src/server/project.ts
@@ -198,13 +198,13 @@ namespace ts.server {
return hasOneOrMoreJsAndNoTsFiles(this);
}

public static resolveModule(moduleName: string, initialDir: string, host: ServerHost, log: (message: string) => void): {} | undefined {
public static resolveModule(moduleName: string, initialDir: string, host: ServerHost, log: (message: string) => void, logErrors?: (message: string) => void): {} | undefined {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how bad is an API break? it would be less confusing just to require logErrors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure who we will break so its better to just have it optional I think

@sheetalkamat sheetalkamat merged commit b724c13 into master May 24, 2019
@sheetalkamat sheetalkamat deleted the noLogWhenPluginFound branch May 24, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@andrewbranch andrewbranch andrewbranch approved these changes

@rbuckton rbuckton Awaiting requested review from rbuckton

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@weswigham weswigham Awaiting requested review from weswigham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't log errors when a TS Server plugin is not found in one folder but is eventually resolved
3 participants
@sheetalkamat @sandersn @andrewbranch