Stop invalidating module resolution cache when saving an open file #31685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
requested changes
May 31, 2019
sheetalkamat
approved these changes
May 31, 2019
uniqueiniquity
added a commit
to uniqueiniquity/TypeScript
that referenced
this pull request
Jun 12, 2019
…ngOnOpenFileSave Stop invalidating module resolution cache when saving an open file
uniqueiniquity
added a commit
that referenced
this pull request
Jun 12, 2019
Port #31685 to release-3.5
This was referenced Sep 24, 2019
This was referenced Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Visual Studio, we currently trigger directory watchers when saving an open file.
In projects with sufficiently large dependencies (i.e., the ASP.NET Core Angular template), this causes the module resolution cache to be entirely invalidated, thereby triggering a seconds-long
updateGraphoperation to occur.This change aims to prevent this scenario by checking if the file whose change triggered the directory watcher is still open and, if so, not invalidating the cache.