Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot framework V4. Unable to use ⭐ emoji in suggested actions #4007

Closed
kevit-samir-katyar opened this issue Dec 8, 2021 · 3 comments · Fixed by #4031
Closed

Bot framework V4. Unable to use ⭐ emoji in suggested actions #4007

kevit-samir-katyar opened this issue Dec 8, 2021 · 3 comments · Fixed by #4031
Assignees
@JuanAr
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Issue is created by anyone that is not a collaborator in the repository. needs-triage The issue has just been created and it has not been reviewed by the team.
Milestone
R16

Comments

@kevit-samir-katyar
Copy link

Versions

What package version of the SDK are you using - 4.1.6
What nodejs version are you using - v14.18.2
What browser version are you using - Chrome
What os are you using - ubuntu

Describe the bug

I need to implement rating\review functionality in one of my bots. My plan was to use suggested actions and emojis in a waterfall dialog. As soon as I use star ⭐ in the options, the dialog does not go to the next step when this option is selected. It does work for other emoji-like 😁
I am testing it in the emulator..

async askFeedbackStep(stepContext) {
const CHOICES = ['⭐','😀'];
return await stepContext.prompt(FEEDBACK_PROMPT, {
choices: ChoiceFactory.toChoices(CHOICES),
style: ListStyle.suggestedAction
});
}
}

So if the user selects the first option with the code below, the option is not accepted and the dialog prompt is shown again. With the second option, the dialog goes to the next step.

Screenshots

image
@kevit-samir-katyar kevit-samir-katyar added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Dec 8, 2021
@stevkan stevkan added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Dec 8, 2021
@mrivera-ms mrivera-ms added this to the R16 milestone Dec 8, 2021
@kevit-samir-katyar
Copy link
Author

@JuanAr can i get any update on this

@ceciliaavila
Copy link
Collaborator

Hi @kevit-samir-katyar, thanks for opening this issue. This is currently in our backlog and we'll be reviewing this issue this week.

@kevit-samir-katyar
Copy link
Author

@ceciliaavila sure

@ceciliaavila ceciliaavila mentioned this issue Dec 20, 2021
Merged
mrivera-ms pushed a commit that referenced this issue Jan 3, 2022
@ceciliaavila
fix: [#4007] Bot framework V4. Unable to use ⭐ emoji in suggested act…
5909b69 
…ions (#4031)

* Add findExactMatch function for choices

* Update findExactMatch function to match .net impl.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Issue is created by anyone that is not a collaborator in the repository. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Milestone
R16
Development

Successfully merging a pull request may close this issue.

fix: [#4007] Bot framework V4. Unable to use ⭐ emoji in suggested actions microsoft/botbuilder-js
5 participants
@JuanAr @stevkan @ceciliaavila @mrivera-ms @kevit-samir-katyar