Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/playwright
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.24.1
Choose a base ref
...
head repository: microsoft/playwright
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.24.2
Choose a head ref
  • 2 commits
  • 20 files changed
  • 2 contributors

Commits on Jul 27, 2022

  1. cherry-pick(#15979): Revert "fix(test runner): ignore undefined value…

    …s in fixtures definitions (#15119)" (#15996)
    
    cherry-pick(#15979): Revert "fix(test runner): ignore undefined values in fixtures definit…ions (#15119)"
    
    Revert commit d7b63fa.
    Add a test for the broken behavior.
    dgozman authored Jul 27, 2022
    Copy the full SHA
    bd6f228 View commit details

Commits on Jul 29, 2022

  1. Copy the full SHA
    0eb8a70 View commit details
20 changes: 10 additions & 10 deletions docs/src/ci.md
Original file line number Diff line number Diff line change
@@ -176,7 +176,7 @@ steps:
name: 'Playwright Tests'
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.24.1-focal
image: mcr.microsoft.com/playwright:v1.24.2-focal
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v2
@@ -194,7 +194,7 @@ steps:
name: 'Playwright Tests'
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.24.1-focal
image: mcr.microsoft.com/playwright:v1.24.2-focal
steps:
- uses: actions/checkout@v3
- name: Set up Python
@@ -218,7 +218,7 @@ steps:
name: 'Playwright Tests'
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.24.1-focal
image: mcr.microsoft.com/playwright:v1.24.2-focal
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
@@ -239,7 +239,7 @@ steps:
name: 'Playwright Tests'
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.24.1-focal
image: mcr.microsoft.com/playwright:v1.24.2-focal
steps:
- uses: actions/checkout@v3
- name: Setup dotnet
@@ -264,7 +264,7 @@ steps:
name: 'Playwright Tests - ${{ matrix.project }} - Shard ${{ matrix.shardIndex }} of ${{ matrix.shardTotal }}'
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.24.1-focal
image: mcr.microsoft.com/playwright:v1.24.2-focal
strategy:
fail-fast: false
matrix:
@@ -297,7 +297,7 @@ Alternatively, you can use [Command line tools](./cli.md#install-system-dependen
pool:
vmImage: 'ubuntu-20.04'
container: mcr.microsoft.com/playwright:v1.24.1-focal
container: mcr.microsoft.com/playwright:v1.24.2-focal
steps:
...
@@ -311,7 +311,7 @@ Running Playwright on CircleCI requires the following steps:

```yml
docker:
- image: mcr.microsoft.com/playwright:v1.24.1-focal
- image: mcr.microsoft.com/playwright:v1.24.2-focal
environment:
NODE_ENV: development # Needed if playwright is in `devDependencies`
```
@@ -333,7 +333,7 @@ to run tests on Jenkins.

```groovy
pipeline {
agent { docker { image 'mcr.microsoft.com/playwright:v1.24.1-focal' } }
agent { docker { image 'mcr.microsoft.com/playwright:v1.24.2-focal' } }
stages {
stage('e2e-tests') {
steps {
@@ -351,7 +351,7 @@ pipeline {
Bitbucket Pipelines can use public [Docker images as build environments](https://confluence.atlassian.com/bitbucket/use-docker-images-as-build-environments-792298897.html). To run Playwright tests on Bitbucket, use our public Docker image ([see Dockerfile](./docker.md)).

```yml
image: mcr.microsoft.com/playwright:v1.24.1-focal
image: mcr.microsoft.com/playwright:v1.24.2-focal
```

### GitLab CI
@@ -364,7 +364,7 @@ stages:
tests:
stage: test
image: mcr.microsoft.com/playwright:v1.24.1-focal
image: mcr.microsoft.com/playwright:v1.24.2-focal
script:
...
```
24 changes: 12 additions & 12 deletions docs/src/docker.md
Original file line number Diff line number Diff line change
@@ -14,19 +14,19 @@ This image is published on [Docker Hub].
### Pull the image

```bash js
docker pull mcr.microsoft.com/playwright:v1.24.1-focal
docker pull mcr.microsoft.com/playwright:v1.24.2-focal
```

```bash python
docker pull mcr.microsoft.com/playwright/python:v1.24.1-focal
docker pull mcr.microsoft.com/playwright/python:v1.24.2-focal
```

```bash csharp
docker pull mcr.microsoft.com/playwright/dotnet:v1.24.1-focal
docker pull mcr.microsoft.com/playwright/dotnet:v1.24.2-focal
```

```bash java
docker pull mcr.microsoft.com/playwright/java:v1.24.1-focal
docker pull mcr.microsoft.com/playwright/java:v1.24.2-focal
```

### Run the image
@@ -38,39 +38,39 @@ By default, the Docker image will use the `root` user to run the browsers. This
On trusted websites, you can avoid creating a separate user and use root for it since you trust the code which will run on the browsers.

```bash js
docker run -it --rm --ipc=host mcr.microsoft.com/playwright:v1.24.1-focal /bin/bash
docker run -it --rm --ipc=host mcr.microsoft.com/playwright:v1.24.2-focal /bin/bash
```

```bash python
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/python:v1.24.1-focal /bin/bash
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/python:v1.24.2-focal /bin/bash
```

```bash csharp
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/dotnet:v1.24.1-focal /bin/bash
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/dotnet:v1.24.2-focal /bin/bash
```

```bash java
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/java:v1.24.1-focal /bin/bash
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/java:v1.24.2-focal /bin/bash
```

#### Crawling and scraping

On untrusted websites, it's recommended to use a separate user for launching the browsers in combination with the seccomp profile. Inside the container or if you are using the Docker image as a base image you have to use `adduser` for it.

```bash js
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright:v1.24.1-focal /bin/bash
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright:v1.24.2-focal /bin/bash
```

```bash python
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/python:v1.24.1-focal /bin/bash
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/python:v1.24.2-focal /bin/bash
```

```bash csharp
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/dotnet:v1.24.1-focal /bin/bash
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/dotnet:v1.24.2-focal /bin/bash
```

```bash java
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/java:v1.24.1-focal /bin/bash
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/java:v1.24.2-focal /bin/bash
```

[`seccomp_profile.json`](https://github.com/microsoft/playwright/blob/main/utils/docker/seccomp_profile.json) is needed to run Chromium with sandbox. This is a [default Docker seccomp profile](https://github.com/docker/engine/blob/d0d99b04cf6e00ed3fc27e81fc3d94e7eda70af3/profiles/seccomp/default.json) with extra user namespace cloning permissions:
2 changes: 1 addition & 1 deletion docs/src/release-notes-js.md
Original file line number Diff line number Diff line change
@@ -234,7 +234,7 @@ Read more about [component testing with Playwright](./test-components).
}
});
```
* Playwright now runs on Ubuntu 22 amd64 and Ubuntu 22 arm64. We also publish new docker image `mcr.microsoft.com/playwright:v1.24.1-jammy`.
* Playwright now runs on Ubuntu 22 amd64 and Ubuntu 22 arm64. We also publish new docker image `mcr.microsoft.com/playwright:v1.24.2-jammy`.

### ⚠️ Breaking Changes ⚠️

2 changes: 1 addition & 1 deletion docs/src/test-snapshots-js.md
Original file line number Diff line number Diff line change
@@ -56,7 +56,7 @@ The snapshot name `example-test-1-chromium-darwin.png` consists of a few parts:
If you are not on the same operating system as your CI system, you can use Docker to generate/update the screenshots:

```bash
docker run --rm --network host -v $(pwd):/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.24.1-focal /bin/bash
docker run --rm --network host -v $(pwd):/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.24.2-focal /bin/bash
npm install
npx playwright test --update-snapshots
```
Loading