Fix #251 #308
Merged
Fix #251 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add TypeScript binding to allow instantiating BigNumber without the `new` keyword
|
Does it work? |
|
I've modified bignumber.d.ts in an existing TypeScript project within the node_modules directory, and TypeScript is happy with the change. I haven't done any thorough testing, but this alleviates the TypeScript error and I can't imagine it would have any negative side-effects. |
|
Okay, I'll try and test it more thoroughly during the week. |
|
@MikeMcl whats the status on this? would be nice to have now that we migrate to typescript! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TypeScript binding to allow instantiating
BigNumberwithout thenewkeywordI opted against adding jsdoc to this binding, only because there was no way to link directly to the constructor itself.