Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exports field to package.json #322

Merged
merged 2 commits into from May 25, 2022
Merged

Conversation

perrin4869
Copy link
Contributor

This solves rollup/plugins#1130
Bundling json-bigint with rollup fails without this change.

@shuckster
Copy link

Just wanted to say that the ordering of the exports and the inclusion of a default can make a difference to WebPack and esbuild, as I recently discovered with my own small modules.

@MikeMcl
Copy link
Owner

MikeMcl commented Mar 7, 2022

Looks good. I'll consider it.

See #300 for previous on exports.

@ShenHongFei
Copy link

LGTM
Fixed type error for TypeScript nodenext module type

@MikeMcl MikeMcl merged commit d4291cb into MikeMcl:master May 25, 2022
@MikeMcl
Copy link
Owner

MikeMcl commented May 25, 2022

Okay, thank you.

@coldcode001
Copy link

coldcode001 commented Aug 4, 2022

@MikeMcl Is there any plan to publish a new release containing this fix? I'm waiting for this to fix a critical webpack issue, would appreciate if it can be released soon.

@MikeMcl
Copy link
Owner

MikeMcl commented Aug 8, 2022

@coldcode001

Published v9.1.0.

Thanks for the nudge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants