Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Half Odd Rounding mod #175

Open
Saka7 opened this issue Apr 16, 2021 · 2 comments
Open

Half Odd Rounding mod #175

Saka7 opened this issue Apr 16, 2021 · 2 comments

Comments

@Saka7
Copy link

Saka7 commented Apr 16, 2021

Any plans to support Half-odd Rounding mode?
@MikeMcl
Copy link
Owner

MikeMcl commented Apr 16, 2021

No, but I'm not against it.
I think I should probably have included it from the beginning, but I think I just used the rounding modes from Java's BigDecimal.

@jormaechea
Copy link

Hi @MikeMcl! I was just trying to implement rounding standard from Brazil, ABNT NBR 5891 and realized that it is actually ROUND_HALF_ODD. Sadly, it's missing.

I'll try to make some time to implement it and make a PR. But I have a question:

How do you handle new features between this and decimal.js-light? I think this should be implemented in both libs, right? Implementations are independent between packages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MikeMcl @jormaechea @Saka7