Support JAD parameter names as configurable option #28
Comments
aikar
added a commit
to PaperMC/Paper
that referenced
this issue
Aug 31, 2018
ForgeFlower is better than Spigots FernFlower at decompiling the source. However, in order to maintain the CraftBukkit patches, we must keep using spigots for the primary. However, for any file that we import on top of Spigots imported files there is nothing stopping us from using better decompiled files. So these changes will use ForgeFlower to maintain a better set of decomped files, so anything we add on top of Paper can start off in a better spot. However, ForgeFlower is not giving JAD style parameter names, and I'm waiting for MinecraftForge/ForgeFlower#28 to be resolved in order to keep parameter names the same as spigots. Once that is resolved, I can then update ForgeFlower and solve mc-dev fix conflicts and get us on an updated baseline. Initial comparison shows much better decompile results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/MinecraftForge/ForgeFlower/blob/master/FernFlower-Patches/0012-JAD-Style-variable-naming.patch#L477
This is hard coded false with no visible way to change it.
I'm having trouble building the project, so hoping someone can assist in making this option configurable?
The text was updated successfully, but these errors were encountered: