Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download stuck when a request fails #28

Open
DFFZMXJ opened this issue Jan 10, 2020 · 3 comments
Open

Download stuck when a request fails #28

DFFZMXJ opened this issue Jan 10, 2020 · 3 comments

Comments

@DFFZMXJ
Copy link

DFFZMXJ commented Jan 10, 2020

In #27 , I said I encountered the same problem as that guy. Actually, as I observe, it seems a little different. When my download progress is stuck, I can see this in F12:

image

Its response:

{
  "message": "API rate limit exceeded for 45.32.27.8. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)",
  "documentation_url": "https://developer.github.com/v3/#rate-limiting"
}

Your program requests too frequently but won't retry when failing. Therefore the download will fail even if only one error occurs. I suggest retrying for 3 times at least or set a button.

@luki1412
Copy link

Im getting:
Failed to load resource: net::ERR_INSUFFICIENT_RESOURCES
and
Failed to load resource: the server responded with a status of 403 (Forbidden)

UI/web page should also display an error of some sort.

@MinhasKamal
Copy link
Owner

Yes, some sort of error message would help. I'll try to get into it as soon as I can.

@metroite
Copy link

metroite commented Apr 13, 2020

I think its related to this: If the target is too big, it gets stuck and loads indefinitely. On GitZip it works. I assume its because of the Github API Access Token which can be assigned in GitZip.

Where can I embed that token in the code? I assume somewhere in down-git.js?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants