Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Custom Authorizer of the REQUEST type #1159

Open
james-burke-codes opened this issue Oct 7, 2017 · 5 comments · May be fixed by #2093
Open

Support for Custom Authorizer of the REQUEST type #1159

james-burke-codes opened this issue Oct 7, 2017 · 5 comments · May be fixed by #2093
Labels
aws

Comments

@james-burke-codes
Copy link

Context

It is now possible when creating a custom authorizer for API Gateways to set a REQUEST type event payload which will pass all headers instead of just the authorization token header.

http://docs.aws.amazon.com/apigateway/latest/developerguide/use-custom-authorizer.html#api-gateway-custom-authorizer-request-lambda-function-create

Is there any plan to integrate this into Zappa?
@Miserlou
Copy link
Owner

Miserlou commented Oct 7, 2017

Sounds great! Send over a PR!

@jcronyn
Copy link

jcronyn commented Dec 8, 2017 •
edited

Investigated this and it doesn't appear that Cloudformation currently supports accepting REQUEST as the Type for an Authorizer

http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-authorizer.html#w2ab2c21c10c22c13

@scoates scoates mentioned this issue Feb 28, 2018
Open
@scoates
Copy link
Collaborator

scoates commented Feb 28, 2018

Marked cantfix until we get a way to do this on CFN.

@ionutm82
Copy link

ionutm82 commented Apr 18, 2018 •
edited by scoates

Hi,

I talked to AWS support engineers and it seems that there is a bug in documentation. The Cloudformation support is already there. Below is a template I received from AWS support:

{
    "AWSTemplateFormatVersion": "2010-09-09",
    "Resources": {
        "RestAPI": {
            "Type": "AWS::ApiGateway::RestApi",
            "Properties": {
                "Name": "RestAPI"
            }
        },
        "Authorizer": {
            "Type": "AWS::ApiGateway::Authorizer",
            "Properties": {
                "AuthorizerUri": "arn:aws:apigateway:region:lambda:path/path/invocations",
                "IdentitySource": "method.request.header.Auth",
                "Name": "Authorizer",
                "RestApiId": {
                    "Ref": "RestAPI"
                },
                "Type": "REQUEST"
            }
        }
    }
}

Can you, please, let me know when we can have this feature in Zappa?

[Edit: formatting –@scoates]

@scoates scoates removed the cantfix label Apr 18, 2018
@M0dM M0dM mentioned this issue Jun 18, 2018
Closed
@scoates scoates mentioned this issue Oct 16, 2018
Closed
@jcgodino
Copy link

Hello, is there a plan to implement the 'REQUEST' type?

@tommie-lie tommie-lie linked a pull request Apr 30, 2020 that will close this issue
Open
@jneves jneves mentioned this issue Feb 20, 2021
Closed
@ppartarr ppartarr mentioned this issue Feb 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for REQUEST type Lambda Authorizers tommie-lie/Zappa
6 participants
@scoates @Miserlou @james-burke-codes @jcgodino @jcronyn @ionutm82