Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't save renaming settings when to long #139

Open
OliverZachau opened this issue Feb 12, 2021 · 1 comment
Open

Can't save renaming settings when to long #139

OliverZachau opened this issue Feb 12, 2021 · 1 comment
Assignees
Labels

Comments

@OliverZachau
Copy link

Describe the bug
Saving a long list of renames is resulting in:
Unchecked runtime.lastError: QUOTA_BYTES_PER_ITEM quota exceeded

When you have rewrites for 200+ eVars and a lot of props for Adobe Analytics this can quickly add up.

To Reproduce
Steps to reproduce the behavior:
(Version 88.0.4324.150 (Offizieller Build) (x86_64))

  1. Go to 'Omnibug Settings'
  2. (Open the console to see errors)
  3. Enter a valid JSON formatted string which is > 8,192 bytes in the renaming parameter box
  4. Click outside the box for "saving"
  5. Error "Unchecked runtime.lastError: QUOTA_BYTES_PER_ITEM quota exceeded" appears in log
  6. Close the settings
  7. Open the settings
  8. Input wasn't saved

Expected behavior
Information is saved and the renaming of parameters is working

Desktop (please complete the following information):

  • OS: Mac OS 10.15.7
  • Browser chrome
  • Version Version 88.0.4324.150 (Offizieller Build) (x86_64)
  • Omnibug Version v1.17.3

Additional context

Proposed fix:
https://stackoverflow.com/questions/33015723/unchecked-runtime-lasterror-while-running-storage-set-quota-bytes-per-item-quot

Either switching from sync -> local storage OR adding in the manifest.json permissions for "unlimitedStorage"

@MisterPhilip MisterPhilip self-assigned this Feb 12, 2021
@ojusn
Copy link

ojusn commented May 4, 2021

Hello there!

I am seeing the same error as well for the Rename parameters Option.
I have a long string for multiple re-writes as well.

Would love to see this fixed soon. Thank you!

Windows 10 Machine - Chrome Version 90.0.4430.93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

3 participants