From 89a5d04a8ecab2d0a804d43a4369456315c43bee Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Tue, 4 Apr 2023 21:59:26 +0200 Subject: [PATCH] doc: do not create a backup file The `sed -i -- 's_^#include "chromeconf.h"_//#include "chromeconf.h"_' deps/zlib/zconf.h` command creates a `zconf.h--` backup file on macOS. Replace it with an equivalent perl one-liner so that it works on both Linux and macOS. PR-URL: https://github.com/nodejs/node/pull/47151 Reviewed-By: Yagiz Nizipli Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Richard Lau Reviewed-By: Michael Dawson --- doc/contributing/maintaining-zlib.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-zlib.md b/doc/contributing/maintaining-zlib.md index 75c2b54c04a73a..35a6d82299c005 100644 --- a/doc/contributing/maintaining-zlib.md +++ b/doc/contributing/maintaining-zlib.md @@ -15,7 +15,7 @@ mv zlib deps/ mv deps/zlib.gyp deps/GN-scraper.py deps/zlib/ mkdir deps/zlib/win32 mv deps/zlib.def deps/zlib/win32 -sed -i -- 's_^#include "chromeconf.h"_//#include "chromeconf.h"_' deps/zlib/zconf.h +perl -i -pe 's|^#include "chromeconf.h"|//#include "chromeconf.h"|' deps/zlib/zconf.h ``` Check that Node.js still builds and tests.