Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish Store5 Migration Guide #532

Open
matt-ramotar opened this issue Mar 9, 2023 · 3 comments
Open

Publish Store5 Migration Guide #532

matt-ramotar opened this issue Mar 9, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@matt-ramotar
Copy link
Collaborator

matt-ramotar commented Mar 9, 2023 •
edited

What we hit at Dropbox

  • Store-rx2 only has bindings for Store4. We are considering adding Rx support to Store5: Support Rx2 #531. We are not sure we want to commit to supporting Rx "forever". Right now folks need to add their own Rx support
  • StoreRequest renamed to StoreReadRequest
  • StoreResponse renamed to StoreReadResponse
  • StoreBuilder modified to also take a Network generic parameter. We added a Network generic parameter with the introduction of Converter. Because Store4 had no concept of conversion, for every existing usage, Network generic is equal to Output generic
  • clearAll renamed to clear
  • Store library moved from Dropbox to MobileNativeFoundation
@matt-ramotar matt-ramotar added the documentation Improvements or additions to documentation label Mar 9, 2023
@digitalbuddha
Copy link
Contributor

I'm going to split out a converting builder to undo the breaking change with store4 builder

@laurenyew-nytimes
Copy link

+1 would like a migration guide.

@matt-ramotar matt-ramotar mentioned this issue Mar 31, 2023
Merged
@inktomi
Copy link

inktomi commented Jun 9, 2023

The docs should include a mapping for the new package names as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
Store Roadmap
Status: 🏗 In progress
Milestone
No milestone
Development

No branches or pull requests
4 participants
@inktomi @digitalbuddha @matt-ramotar @laurenyew-nytimes