Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populating documentURL for other BuildStepTypes #65

Open
mobileben opened this issue Feb 26, 2020 · 2 comments
Open

Populating documentURL for other BuildStepTypes #65

mobileben opened this issue Feb 26, 2020 · 2 comments

Comments

@mobileben
Copy link

I realize this is something that Apple is doing with their xcactivitylog. It appears with CompileC and CompileSwift that the documentURL will contain the file name of the file that is being compiled. This is populated by the DVTDocumentLocation.

It seems it would also be useful to have this information available to other compile types such as CompileStoryboard and CompileXIB. It does look like we should be able to derive this from the title.

@mobileben
Copy link
Author

mobileben commented Feb 26, 2020

I took a look more at the code. This isn't as straight forward as I initially thought it would be because of the way BuildStep objects are initialized.

A possibility would be to hijack one of the addCompilationTimes variants to accomplish this.

Would that be considered too messy and potentially error prone?

@PatrikBillgren
Copy link
Collaborator

Hi @mobileben! Is this issue still valid? In that case, do you have a POC PR to demonstrate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants