Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should change all references of "SwiftUI Previews" to "Xcode Previews" #2554

Open
brentleyjones opened this issue Sep 7, 2023 · 1 comment
Open

Should change all references of "SwiftUI Previews" to "Xcode Previews" #2554

brentleyjones opened this issue Sep 7, 2023 · 1 comment
Labels
cleanup Development cleanup
Milestone
Desired but not p...

Comments

@brentleyjones
Copy link
Contributor

"Xcode Previews" is their official name, and they now support more than just SwiftUI.
@brentleyjones brentleyjones added the cleanup Development cleanup label Sep 7, 2023
@adincebic adincebic mentioned this issue Dec 16, 2023
Merged
brentleyjones added a commit that referenced this issue Jan 2, 2024
@adincebic @brentleyjones
Change all references of "SwiftUI Previews" to "Xcode Previews" (#2797)
6854df4 
Related to
#2554

---------

Signed-off-by: Adin Cebic <cebic.ad@gmail.com>
Signed-off-by: Brentley Jones <github@brentleyjones.com>
Co-authored-by: Brentley Jones <github@brentleyjones.com>
@brentleyjones
Copy link
Contributor Author

We have partially done this in #2797. Remaining work would be in variable names and the rules_xcodeproj_swiftui config (which would be a breaking change, so not sure how to go about doing that one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Development cleanup
Projects
None yet
Milestone
Desired but not prioritized
Development

No branches or pull requests
1 participant
@brentleyjones