Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Xcode Previews fail to find transitive frameworks when using --define=apple.experimental.tree_artifact_outputs=0 #2641

Open
brentleyjones opened this issue Sep 29, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@brentleyjones
Copy link
Contributor

Description

We don't unarchive transitive frameworks when copying them over to SwiftUIPreviewsFrameworks. This is an issue when using --define=apple.experimental.tree_artifact_outputs=0.

Reproduction steps

In examples/integration (which currently sets --define=apple.experimental.tree_artifact_outputs=0) try to use the UI Xcode Preview.

Expected behavior

We shouldn't unarchive artifacts in copy_outputs.sh. Instead we should generate an unarchiving action, and depend on that instead in the output groups. Then, regardless of what apple.experimental.tree_artifact_outputs is set to, we will always have a tree artifact.

rules_xcodeproj version

1.11.0

Xcode version

15.0

Bazel version

6.4.0rc1

rules_apple version

No response

rules_swift version

No response

Additional information

No response

@brentleyjones brentleyjones added the bug Something isn't working label Sep 29, 2023
@brentleyjones brentleyjones self-assigned this Sep 29, 2023
brentleyjones added a commit that referenced this issue Dec 6, 2023
Part of #2641.

This gets us most of the way to fixing Xcode Previews when not using
tree artifacts. The last thing needed is adding these products to an
output group for Xcode previews, otherwise unfocused frameworks aren’t
extracted.

---------

Signed-off-by: Brentley Jones <github@brentleyjones.com>
@brentleyjones
Copy link
Contributor Author

As of #2779:

The last thing needed is adding these products to an output group for Xcode previews, otherwise unfocused frameworks aren’t extracted.

@brentleyjones brentleyjones changed the title Bug: BwB Xcode Previews fail to find transitive frameworks when using --define=apple.experimental.tree_artifact_outputs=0 Bug: Xcode Previews fail to find transitive frameworks when using --define=apple.experimental.tree_artifact_outputs=0 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant