You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We don't unarchive transitive frameworks when copying them over to SwiftUIPreviewsFrameworks. This is an issue when using --define=apple.experimental.tree_artifact_outputs=0.
Reproduction steps
In examples/integration (which currently sets --define=apple.experimental.tree_artifact_outputs=0) try to use the UI Xcode Preview.
Expected behavior
We shouldn't unarchive artifacts in copy_outputs.sh. Instead we should generate an unarchiving action, and depend on that instead in the output groups. Then, regardless of what apple.experimental.tree_artifact_outputs is set to, we will always have a tree artifact.
rules_xcodeproj version
1.11.0
Xcode version
15.0
Bazel version
6.4.0rc1
rules_apple version
No response
rules_swift version
No response
Additional information
No response
The text was updated successfully, but these errors were encountered:
Part of #2641.
This gets us most of the way to fixing Xcode Previews when not using
tree artifacts. The last thing needed is adding these products to an
output group for Xcode previews, otherwise unfocused frameworks aren’t
extracted.
---------
Signed-off-by: Brentley Jones <github@brentleyjones.com>
The last thing needed is adding these products to an output group for Xcode previews, otherwise unfocused frameworks aren’t extracted.
brentleyjones
changed the title
Bug: BwB Xcode Previews fail to find transitive frameworks when using --define=apple.experimental.tree_artifact_outputs=0
Bug: Xcode Previews fail to find transitive frameworks when using --define=apple.experimental.tree_artifact_outputs=0Mar 20, 2024
Description
We don't unarchive transitive frameworks when copying them over to
SwiftUIPreviewsFrameworks
. This is an issue when using--define=apple.experimental.tree_artifact_outputs=0
.Reproduction steps
In
examples/integration
(which currently sets--define=apple.experimental.tree_artifact_outputs=0
) try to use theUI
Xcode Preview.Expected behavior
We shouldn't unarchive artifacts in
copy_outputs.sh
. Instead we should generate an unarchiving action, and depend on that instead in the output groups. Then, regardless of whatapple.experimental.tree_artifact_outputs
is set to, we will always have a tree artifact.rules_xcodeproj version
1.11.0
Xcode version
15.0
Bazel version
6.4.0rc1
rules_apple version
No response
rules_swift version
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: