Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Missed Tests #542

Merged
merged 16 commits into from
Jul 22, 2022
Merged

Add Missed Tests #542

merged 16 commits into from
Jul 22, 2022

Conversation

thelooter
Copy link
Contributor

Description

Add missed Tests

Checklist

The following items should be checked before the pull request can be merged.

  • Unit tests added.
  • Code follows existing code format.

Info on creating a pull request

  • Make sure that unit tests are added which test the relevant changes.
  • Make sure that the changes follow the existing code format.

For maintainer

When a PR is approved, the maintainer should label this PR with release/*.

  • If the PR fixes a bug in MockBukkit, update the patch version. (if the current version is 0.4.1, the new version should be 0.4.2)
  • If the PR adds a new feature to MockBukkit, update minor version. (if the current version is 0.4.1, the new version should be 0.5.0)

Note that a PR that fixes an UnimplementedOperationException should be considered a new version and not a bugfix.

Insprill
Insprill requested changes Jul 12, 2022
View reviewed changes
.github/workflows/gradle.yml Outdated Show resolved Hide resolved
src/test/java/be/seeseemelk/mockbukkit/entity/PlayerMockTest.java Outdated Show resolved Hide resolved
@seeseemelk seeseemelk requested a review from a team as a code owner July 14, 2022 12:13
@thelooter thelooter linked an issue Jul 14, 2022 that may be closed by this pull request
Add Tests that have been missed in the past #479
Open
@thelooter thelooter requested a review from Insprill July 21, 2022 04:29
Insprill
Insprill approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@Insprill Insprill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@Insprill Insprill merged commit ba70239 into MockBukkit:v1.19 Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Insprill Insprill Insprill approved these changes

Assignees
No one assigned
Labels
release/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Tests that have been missed in the past
3 participants
@thelooter @Insprill @seeseemelk