MockBukkit services are overriden with Paper ones when using PaperWeight

[Insprill]

Is there an existing issue for this?

• I have searched the existing issues

Are you using the latest version of MockBukkit?

• I am using the latest version of MockBukkit.

Minecraft Version

1.19

Describe the bug

When using Paperweight, MockBukkit's services get overridden with Paper ones, causing tests to fail.

Reproducible Test

build.gradle:

plugins {
    id 'java'
    id 'io.papermc.paperweight.userdev' version "1.3.8"
}

dependencies {
    paperweightDevelopmentBundle('io.papermc.paper:dev-bundle:1.19.1-R0.1-SNAPSHOT')
    // MockBukkit and JUnit
}

settings.gradle:

pluginManagement {
    repositories {
        gradlePluginPortal()
        maven { url = 'https://papermc.io/repo/repository/maven-public/' }
    }
}

Test:

@Test
void test() {
    LegacyComponentSerializer.legacySection(); // Fails
}

Anything else?

No response

[syldium]

There are several workarounds depending on the project:

• If NMS classes are not needed for the tests to run, then excluding the paper-server module is the way to go:

configurations.testImplementation {
    exclude(group: "io.papermc.paper", module: "paper-server")
} 

• If the tests need the paper-server module, then you have to transform the dependency in order to exclude the /META-INF/services/net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializer$Provider file. This is feasible, but not very handy.

Now, on the MockBukkit side, it might be better to use reflection instead of Java SPI to set the serializer only if it is not already provided by a service.

[Chaosdave34]

I am also trying to run MockBukkit with PaperMC paperweight and I get the same Error, but I need the NMS classes.
How could I solve the problem?