Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of Deprecated Constructor #900

Open
thelooter opened this issue Nov 11, 2023 · 4 comments
Open

Remove use of Deprecated Constructor #900

thelooter opened this issue Nov 11, 2023 · 4 comments
Assignees

Comments

@thelooter
Copy link
Contributor

BlockDamageEvent event = new BlockDamageEvent(this, block, getItemInHand(), false);

The used Constructor for BlockDamageEventis annotated as Deprecated for Removal and and DoNotUse. Therefore we should replace this Constructor

@JonnyMc94
Copy link

Hi, I would like to work on this issue. Could you assign it to me?

@thelooter
Copy link
Contributor Author

Sure, done

@JonnyMc94
Copy link

@thelooter I can't seem to find a depreciation marker or a discussion about possible deprecation of this constructor anywhere. Could you point me in the direction of some info on it?

This file only has one constructor
https://github.com/Bukkit/Bukkit/blob/master/src/main/java/org/bukkit/event/block/BlockDamageEvent.java

@thelooter
Copy link
Contributor Author

We're building on Paper, not Bukkit (which has been unmaintained since 2014), and they have deprecated this constructor as you can see here. Therefore we wanna remove this usage

@JonnyMc94 JonnyMc94 mentioned this issue Nov 13, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants