Reorg: Incorrect behaviour of MemberReference.Is(MemberInfo) extensions with module level on mono

[kohanis]

Description

Because <Module> is an actual type on mono MonoMod.Utils.Extensions.Is(this MemberReference? mref, MemberInfo? minfo) is failing

MonoMod/src/MonoMod.Utils/Extensions.CecilIsRefl.cs

Lines 31 to 34 in 8789285

	var mrefDecl = mref.DeclaringType;
	if (mrefDecl?.FullName == "<Module>")
	mrefDecl = null;

MonoMod/src/MonoMod.Utils/Extensions.CecilIsRefl.cs

Lines 56 to 59 in 8789285

	if (minfo.DeclaringType != null)
	{
	if (mrefDecl == null)
	return false;

Example

using var assemblyDefinition = AssemblyDefinition.CreateAssembly(new AssemblyNameDefinition("TestAssembly", new Version(1, 0)), "MainModule.dll", ModuleKind.Dll);

var moduleType = assemblyDefinition.MainModule.Types.First(m => m.Name == "<Module>");

var testMethod = new MethodDefinition("ModuleTest", MethodAttributes.Static | MethodAttributes.Public, assemblyDefinition.MainModule.TypeSystem.Void);
var il = testMethod.Body.GetILProcessor();
il.Emit(OpCodes.Ret);
moduleType.Methods.Add(testMethod);

using var ms = new MemoryStream();
assemblyDefinition.Write(ms);
var assembly = System.Reflection.Assembly.Load(ms.ToArray());

var reflectMethod = assembly.ManifestModule.GetMethod("ModuleTest");

Console.WriteLine(testMethod.Is(reflectMethod));
Console.WriteLine(reflectMethod.ReflectedType?.FullName ?? "null");

False
<Module>

on mono

[nike4613]

If you don't mind me asking, how are you running into this? Generally, methods on <Module> are extremely rare. The only cases I've found that come out of the C# compiler are a handful of synthesized methods (like an string hash function for large switch statements) or the module initializer itself.

[kohanis]

Test in HarmonyX specifically for this, which stopped working)