Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation and line feed #134

Open
chungwong opened this issue Feb 11, 2021 · 1 comment
Open

Indentation and line feed #134

chungwong opened this issue Feb 11, 2021 · 1 comment

Comments

@chungwong
Copy link

Would you consider using spaces instead of tabs for indentation? And also adding line feeds to all files in the code base.

This will bring consistency across all Pull Requests from different contributors.

@LoganTann
Copy link
Contributor

LoganTann commented Feb 20, 2021

Would you consider using spaces instead of tabs for indentation?

CONTRIBUTING.md file says : Indentation should use 4 space sized Tab characters, not spaces., so using tabs instead of spaces is the choice of the main dev.

And also adding line feeds to all files in the code base.

Do you mean "use CRLF instead of LF in all files" ?

This will bring consistency across all Pull Requests from different contributors.

🤔 Do you mean there are files that uses different kinds of indentations and line feed ? Because with the linter used in this repo, all files should respect the conventions described above

But yes, the code style imposed remains debatable. Most JS open source projects uses spaces + CRLF 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants