Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for running Exercises are incorrect #640

Open
AndreyNikiforov opened this issue Feb 18, 2023 · 2 comments
Open

Instructions for running Exercises are incorrect #640

AndreyNikiforov opened this issue Feb 18, 2023 · 2 comments

Comments

@AndreyNikiforov
Copy link

I am following instructions for running exercises locally and npm install fails with the following error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: @mostly-adequate/exercises@1.0.0
npm ERR! Found: eslint@5.16.0
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^5.9.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^4.9.0" from eslint-config-airbnb@16.1.0
npm ERR! node_modules/eslint-config-airbnb
npm ERR!   dev eslint-config-airbnb@"^16.1.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /home/node/.npm/_logs/2023-02-18T19_36_11_612Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/node/.npm/_logs/2023-02-18T19_36_11_612Z-debug-0.log

Steps to repro:

  • clone repo
  • open vscode with that folder
  • use "Reopen in Container" and choose "Node.js & Typescipt" with v18 from the list
  • follow instructions from the book

Expected behavior:

  • show results of the test run (npm run ch04)

Actual behavior:

  • fails at npm install with error above
@AndreyNikiforov
Copy link
Author

As a mitigation, upgrade/use "eslint-config-airbnb": "^17.0.0", in exercises/package.json/devDependencies

@aurelienlair
Copy link

Thanks @AndreyNikiforov I faced the same issue but with your suggested it fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants