Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit Sonar for Terasology #5244

Open
jdrueckert opened this issue May 8, 2024 · 0 comments
Open

Revisit Sonar for Terasology #5244

jdrueckert opened this issue May 8, 2024 · 0 comments
Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Revive: Keep issue has been looked at and deemed potentially helpful for revive Status: Needs Discussion Requires help discussing a reported issue or provided PR Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity

Comments

@jdrueckert
Copy link
Member

Motivation

We do have sonar tasks in our gradle setup, but as @BenjaminAmos mentioned in a comment on #5194, we neither have any documentation on how to run SonarQube scanner on Terasology engine, nor does it seem to be run in CI.

Proposal

We should decide whether or not we want to keep sonar based on the benefits it brings.
If we decide to keep it, we should properly set up the scanner in CI and document how to run it manually.
For the latter case, we can have a look at our website repo where it is integrated as a GitHub app.

Alternatives

If we decide to not keep it, we should remove the related gradle tasks and dependencies from this repository.

@jdrueckert jdrueckert added Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Status: Needs Discussion Requires help discussing a reported issue or provided PR Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity Revive: Keep issue has been looked at and deemed potentially helpful for revive labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Revive: Keep issue has been looked at and deemed potentially helpful for revive Status: Needs Discussion Requires help discussing a reported issue or provided PR Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity
Projects
Status: No status
Status: No status
Development

No branches or pull requests

1 participant