Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle unpack task fails to overwrite exsting files #549

Open
keturn opened this issue Apr 26, 2020 · 1 comment
Open

gradle unpack task fails to overwrite exsting files #549

keturn opened this issue Apr 26, 2020 · 1 comment

Comments

@keturn
Copy link
Member

keturn commented Apr 26, 2020

This probably doesn't happen very often. If I understand correctly, it'll only be when the version of the java distribution changes, e.g. I changed from 11.0.6 to 11.0.7.

Then it recognized it needed to get the new java version, and it tried to unpack it, but there was already an existing directory for my platform unpacked under jre/. It failed because some of those files are set read-only, so the unpacker can't overwrite them by default.

It's probably a bad idea to unpack one java distribution on top of a previous one anyway. Increased chances for ending up with the wrong version of something, and if a newer version removed or renamed something, the old one will still be left hanging around in that directory.

@keturn
Copy link
Member Author

keturn commented Apr 26, 2020

We could try to be very thorough in fixing this, but if it happens so rarely, I think it's fine to require some manual intervention. Mostly I want a better error message, something like:

jre/${DIRECTORY} already exists, run the cleanJre task to remove it first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant