Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge on green #26

Open
SD10 opened this issue May 7, 2018 · 2 comments
Open

Add merge on green #26

SD10 opened this issue May 7, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@SD10
Copy link
Member

SD10 commented May 7, 2018

We can take Orta's merge on green for use in Moya

I was thinking of having the following two behaviors:

  1. Merge on green
  • If comment from org member contains phrase "Merge on green"
  • PR gets labeled as on green: merge
  • If CI passes and it contains the label, auto merge
  1. Merge on green and delete
  • Same as above but use the phrase "Merge on green and delete"
  • Use the label on green: merge&delete
  • Protected branches are master and development
@SD10 SD10 added the enhancement New feature or request label May 7, 2018
@orta
Copy link
Member

orta commented Jun 1, 2018

Peril has the same access as any user WRT deleting protected branches, so you shouldn't need to add code around that

@SD10
Copy link
Member Author

SD10 commented Jun 2, 2018

My reasoning behind this was a scenario where the development branch was not protected and not wanting to delete that branch as it is a staging area for future PRs. This is probably a small edge case in retrospect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants