Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typse of text method parameters in docs. #2915

Merged
merged 3 commits into from Sep 16, 2020
Merged

Update typse of text method parameters in docs. #2915

merged 3 commits into from Sep 16, 2020

Conversation

izdwuut
Copy link
Contributor

@izdwuut izdwuut commented Sep 15, 2020

A pull request for a documentation issue reported by me.

@izdwuut izdwuut changed the title Update type of text method parameter in docs. Update typse of text method parameters in docs. Sep 15, 2020
@izdwuut
Copy link
Contributor Author

izdwuut commented Sep 15, 2020

I had troubles with transform parameter. Source code says it's number | any, while docs says it's rather number | Matrix. What should we do with it?

@HackbrettXXX
Copy link
Collaborator

Thanks for the PR. The type of the transform parameter is number|Matrix. Could you revert the changes in docs/jsPDF.html? The docs are auto-generated and only updated on release.

@izdwuut
Copy link
Contributor Author

izdwuut commented Sep 16, 2020

This should have been more obvious to me. I reverted the changes and updated jspdf.js annotation.

@HackbrettXXX
Copy link
Collaborator

Thanks. I'll merge it.

This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants