Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undefined Canvg reference #2981

Merged
merged 3 commits into from Oct 29, 2020
Merged

Conversation

antonkri97
Copy link
Contributor

If we will unignore svg.spec.js test file we will get the following error:

TypeError: Cannot read property 'fromString' of undefined
    at <Jasmine>
    at src/modules/svg.js:135:30
    at async UserContext.<anonymous> (test/specs/svg.spec.js:19:5)

After my fix at least we will have access to the required fromString api, but the test will continue to fail due to the incompatibility of different browsers, as indicated in the svg.spec.js source code.

@HackbrettXXX
Copy link
Collaborator

Alright, thanks for the PR :)

@HackbrettXXX HackbrettXXX merged commit b204da1 into parallax:master Oct 29, 2020
This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants