Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudDatePicker 7.0.0 Preview width style visual breaking change #8971

Open
1 of 2 tasks
digitaldirk opened this issue May 14, 2024 · 3 comments
Open
1 of 2 tasks

MudDatePicker 7.0.0 Preview width style visual breaking change #8971

digitaldirk opened this issue May 14, 2024 · 3 comments

Comments

@digitaldirk
Copy link
Contributor

Bug type

Component

Component name

MudDatePicker

What happened?

I use Style="width:150px" on some MudDatePickers which just shrank the input portion and left the picker itself the same. After 7.0.0 preview the input and picker are now both constrained to 150px which breaks the picker visually.

The new 7.X.X behavior might actually be the intended way, and I should probably just constrain the parent of the MudDatePicker which works correctly on 7.X.X. Thoughts on this @henon and team? Or is there a better way to adjust the input portion already? Thanks

7.X.X behavior:

<MudDatePicker Style="width:150px" />

DatePickerWrongSize

6.X.X behavior:

<MudDatePicker Style="width:150px" />

DatePickerRightSize

7.X.X behavior with constrained parent:

<div style="width:150px">
  <MudDatePicker />
</div>

DatePickerRightSizeParent

Expected behavior

Same behavior as 6.X.X

Reproduction link

Reproduction steps

  1. Create a picker as in 7.X.X preview.
  2. Open the date picker and see visually broken picker.

Relevant log output

No response

Version (bug)

7.X.X preview

Version (working)

6.X.X

What browsers are you seeing the problem on?

Firefox, Chrome, Edge

On which operating systems are you experiencing the issue?

Windows

Pull Request

  • I would like to do a Pull Request

Code of Conduct

  • I agree to follow this project's Code of Conduct
@digitaldirk digitaldirk changed the title MudDatePicker Preview 7.0.0 preview width visual breaking change MudDatePicker 7.0.0 Preview width style visual breaking change May 14, 2024
@henon
Copy link
Collaborator

henon commented May 15, 2024

@danielchalmers do you have an idea which PR is responsible for this change in behavior? I am not saying it is necessarily bad behavior, it needs to be determined.

@digitaldirk
Copy link
Contributor Author

Happens in 7.0.0 preview 1, hope that helps narrow it.

I went through a few PRs visually but could not pinpoint a specfic one @danielchalmers @henon

Thank you

@henon
Copy link
Collaborator

henon commented May 15, 2024

@digitaldirk Could you do a git bisect to find the exact commit? It is fairly easy and requires about half an hour of compiling five to seven different commits that bisect checks out for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants