-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opening a profile on launch with lua syntax errors kills the program #7128
Comments
Which Mudlet version is this and on which OS? I just tried 4.17.2 and PTB, and both load okay with the faulty timer code. |
It's with Windows 10 using Mudlet 4.17.202293acc which is the PTB of Feb 9. After work I will try some other setups. |
With a brand new profile, with a timer called Alienware Alpha with Windows 10, Atari VCS with Windows 10: Atari VCS with Windows 11 Atari VCS with Ubuntu 22.04.3 LTS |
Seems like #6846 is doing it. On Ubuntu I made a branch from f76e7a2 which crashes and from the one immediately before it, 2180a34 which stays open. I compiled each one and tested it with command line arg |
Brief summary of issue / Description of requested feature:
Some lua code with a syntax error in it is tolerated mid-session or when launching from the connection dialog, but closes the program if the profile starts with the program. This happens with alias, trigger, timer, keybind, button. With script item it is fine.
Steps to reproduce the issue / Reasons for adding feature:
1 2 3
autologin
file so that you can start the program again in the futureError output / Expected result of feature
Launching it from the command prompt, I see that it puts this line into output:
[LOADING PROFILE]: "C:/Users/Alpha/.config/mudlet/profiles/local-3333/current/2024-02-10#10-31-34.xml" XMLimport::readTimer(...): ERROR: can not compile timer's lua code for: "crasher"
Extra information, such as the Mudlet version, operating system and ideas for how to solve / implement:
I expect there is some variable that tracks errors during startup and failing to compile some lua is treated like a fatal error, and it's treated as a lesser error if you open the profile from the connection dialog. It also might be trying to update a UI element that isn't available yet.
The text was updated successfully, but these errors were encountered: