Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space in mudlet version in reply MXP <VERSION> command. #7140

Open
eowmob opened this issue Feb 11, 2024 · 0 comments
Open

Space in mudlet version in reply MXP <VERSION> command. #7140

eowmob opened this issue Feb 11, 2024 · 0 comments

Comments

@eowmob
Copy link
Contributor

eowmob commented Feb 11, 2024

Brief summary of issue / Description of requested feature:

In some of the 4.17.2 PTB releases a space was introduced into the mudlet version string, resulting
in mudlet returning <VERSION MXP=1.0 CLIENT=Mudlet VERSION=Mudlet 4.17.235144c49> in response to MXP<VERSION>,
which does not parse properly, due to the space in VERSION.

Steps to reproduce the issue / Reasons for adding feature:

  1. Log into any mud using MXP and the <VERSION> command (if you don't know anything else try mud.tap.de:2000)
  2. In mud.tap.de:2000, entering 'set' will show the wrongly parsed version, but there are no other bad effects in this mud.

Error output / Expected result of feature

A mud may misinterprete the MXP version and react badly. However, as of now, no such instance is known.

Extra information, such as the Mudlet version, operating system and ideas for how to solve / implement:

Affects PTB Mudlet 4.17.235144c49 , probably a few PTBs before this as well.
A proper 'xml'-style fix might be to use ...VERSION='%1'... in scmVersionString in TMxpVersionTagHandler.h, but I fear some mud might be unable to deal with the quotes in the version reply. To avoid any issues, I'd opt to use
QString payload = scmVersionString.arg(version.replace(qsl(" "), qsl("-"))
in TMxpVersionTagHandler.cpp instead (or use _ instead of -).

I'd create a PR , but my Windows build environment is broken (now longer compat with dev tree) and (once again) I'm unable to setup a new one. I'll try to use SlySvens recent build alternative, but this does not belong here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant